Review corrections pass #2#4953
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Jan 23, 2020
Merged
Conversation
openshift-ci-robot
added
approved
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
mheon
reviewed
Jan 23, 2020
baude
force-pushed
the
reviewcorrections2
branch
2 times, most recently
from
6c0d7c5 to
dd2b8b5
Compare
baude
force-pushed
the
reviewcorrections2
branch
from
dd2b8b5 to
893caf4
Compare
jwhonce
reviewed
Jan 23, 2020
Add API review comments to correct documentation and endpoints. Also, add a libpode prune method to reduce code duplication. Only used right now for the API but when the remote client is wired, we will switch over there too. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
reviewcorrections2
branch
from
893caf4 to
cf7be58
Compare
jwhonce
approved these changes
Jan 23, 2020
Member
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API review comments to correct documentation and endpoints. Also, add a libpode prune method to reduce code duplication. Only used right now for the API but when the remote client is wired, we will switch over there too.
Signed-off-by: Brent Baude bbaude@redhat.com